Normalize types in implicitScope too
#20138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for the same reason than the normalization in `computeIScope` added by 90c3fbd. IMO, it's already very hard to figure out where `.normalize` should be used, but the fact that it sometimes is only needed under separate compilation is really error-prone and leads to very hard to debug issues. Ideally we should deal with the same types under separate and join compilation. While I'm at it, I added one defensively in `addPath` since I can't tell whether it is needed or not. Fixes scala#20136.
There was a problem hiding this comment.
I pushed our changes with Deferred here, might want to rebase on them
| @@ -724,7 +724,7 @@ trait ImplicitRunInfo: | |||
| companions ++= iscopeRefs(t.underlying) | |||
| end addCompanions | |||
|
|
|||
| def addPath(pre: Type): Unit = pre.dealias match | |||
| def addPath(pre: Type): Unit = pre.dealias.normalized match | |||
There was a problem hiding this comment.
Do you still think we need this given our earlier findings ?
|
Superceded by #20147. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for the same reason than the normalization in
computeIScopeadded by 90c3fbd.IMO, it's already very hard to figure out where
.normalizeshould be used, but the fact that it sometimes is only needed under separate compilation is really error-prone and leads to very hard to debug issues. Ideally we should deal with the same types under separate and join compilation.While I'm at it, I added one defensively in
addPathsince I can't tell whether it is needed or not.Fixes #20136.